added field 'onion_request *' to 'pwrite' request#296
Open
Konstantin9403 wants to merge 8 commits intodavidmoreno:masterfrom
Open
added field 'onion_request *' to 'pwrite' request#296Konstantin9403 wants to merge 8 commits intodavidmoreno:masterfrom
Konstantin9403 wants to merge 8 commits intodavidmoreno:masterfrom
Conversation
Owner
|
Hi, sorry to check this pull request so late, but, can you provide a description here about whats the end goal of adding this feature? Also, I would prefer that instead of returning the function that does the job (listen_point.c:101), it calls the function, as it does with onion_low_malloc and onion_low_free. (low.c) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.